-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add enterprise features #34
Conversation
Ensures that all props for a single column def assume the same underlying value. This means that it's not possible to mix and match types (which would be a bug), and means that the complier can infer types for you (meaning fewer type annotations).
@JordanMarr do you have a preferred way to import and register the enterprise modules? I guess we either need to add a mechanism for doing that, or document how users can do that in their own code. |
I did the following to setup enterprise features:
"ag-grid-community": "^31.3.2",
"ag-grid-enterprise": "^31.3.2",
"ag-grid-react": "^31.3.2", NOTE: The ag-grid documentation stated that both community and enterprise packages need to be loaded.
open Fable.Core.JsInterop
// AG Grid
importSideEffects "ag-grid-enterprise"
importSideEffects "ag-grid-enterprise/styles/ag-grid.css"
importSideEffects "ag-grid-enterprise/styles/ag-theme-balham.css"
//importSideEffects "ag-grid-enterprise/styles/ag-theme-alpine.css"
//importSideEffects "ag-grid-enterprise/styles/ag-theme-material.css" I suppose you could create a helper functions for each of these. |
Checklist for test:
ColumnDef<'row>
AgGrid<'row>
|
This PR is a reworking of #32, with some additions to docs etc. The branch has the code structured as we would prefer and the demo still runs correctly with the community features. Thoughts appreciated @JordanMarr 🙂
The enterprise features still need testing, and this PR will remain in draft until we have tested them.